Page Speed Optimization Libraries
1.7.30.4
|
TODO(sligocki): Find a way to forward declare FileSystem::InputFile.
TODO(gee): Should this be in public? Do we really care?
TODO(gee): Hmm, this sort of sucks.
TODO(skerner): #include image_spriter.pb.h is needed to allow use of enum ImageFormat. Break this dependency and remove the include.
TODO(huibao): Move LibpngImageLibrary to pagespeed/kernel/image/. Refactor LibpngImageLibrary. This class can be split into 3 parts: reader, writer, and canvas creater. The first two parts can be merged with png_optimizer.cc and png_optimizer.h.
TODO(jud): Currently, this implementation just looks at the support value for an individual node to decide if it is below-the-fold or not. It should also combine the support values of a node's parent elements to decide if it's critical. The impact of missing this feature is that some nodes on or near the fold may not be properly considered at BTF, depending on the layout of the page. For example, consider if there is div[1] with a child node div[1]/span[a]. These nodes are close to the fold - clients with a larger screen consider just span[a] below-the-fold, while clients with smaller screens have both div[1] and span[a] below-the-fold. Both screen sizes however have span[a] as below-the-fold. The current implementation won't consider either node to be below-the-fold, since neither will receive enough support. When this
TODO is fixed though, span[a] will be considered below-the-fold, since the support value for div[1] will be added to the support value for span[a].
TODO(sligocki): GoogleString -> GoogleUrl or at least StringPiece.
TODO(sligocki): Include the URL in the fetch, like the request headers.